Handle condition with always true/false sub-condition #3313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.12.x. If your code is relevant on 1.11.x and you want it to be released sooner, please rebase your pull request and change its target to 1.11.x. |
VincentLanglet
force-pushed
the
improveTypeSpecificer
branch
from
d97af04 to
072168e
Compare
VincentLanglet
force-pushed
the
improveTypeSpecificer
branch
from
3b4d594 to
87b3684
Compare
VincentLanglet
commented
Aug 9, 2024
| @@ -349,9 +351,17 @@ public function dataCondition(): iterable | |||
| $this->createFunctionCall('is_int', 'foo'), | |||
| $this->createFunctionCall('is_string', 'bar'), | |||
| ), | |||
| [], | |||
| ['$foo' => 'int'], | |||
There was a problem hiding this comment.
Since bar is an object
$this->scope = $this->scope->assignVariable('bar', new ObjectType('Bar'), new ObjectType('Bar'));
we can be sure foo is an int.
I added the same test with is_int($foo) || is_string($mixed) to reproduce the old behavior.
| @@ -648,19 +658,37 @@ public function dataCondition(): iterable | |||
| [ | |||
| new Expr\Empty_(new Variable('array')), | |||
| [ | |||
| '$array' => 'array{}|null', | |||
There was a problem hiding this comment.
Since array is defined as an non nullable array
$this->scope = $this->scope->assignVariable('array', new ArrayType(new MixedType(), new MixedType()), new ArrayType(new MixedType(), new MixedType()));
we can be sure it's an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11276